Re-pin keep to the v0.9.1 release commit - #472
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request updates the pinned Keep revision in ChangesVersion pin update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Moves
keep.versionfromb06b61fto739cf84, which is the commit keep v0.9.1 is tagged at.Why
#471 pinned
b06b61fand v1.2.0 was tagged there. Cutting keep v0.9.1 then required a workspace version bump, becauserelease.ymlrefuses to build whenCargo.tomldoes not match the tag, so the release commit moved to739cf84. That leftb06b61fas v0.9.1's grandparent rather than the release commit, and the v1.2.0 release notes state that this app pins keep v0.9.1. Re-pinning is what makes that statement true.739cf84also carries a fix thatb06b61fdoes not. The release CI run surfaced RUSTSEC-2026-0224, a signature-verification bypass innostr-relay-pool v0.44.1reached throughnostr-sdk: the verification-cache entry was inserted before the signature check ran, so a first delivery with a bad signature created the entry and a later delivery of the same event ID with a forged signature skipped verification entirely and was persisted as validated. Fixed in 0.44.2, which is in the tree this now pins.The v1.2.0 tag was deleted before publishing anything and will be re-cut on the merge of this PR. No release object or artifact was ever produced under the old pin.
Test plan
verifyKeepVersionpasses against a clean checkout of739cf840.9.1via the same expressionrelease.ymlusesnostr-relay-poolis0.44.2in the pinned treecheck-release-changelogs.shstill passes; the versionCode 28 changelogs from Release v1.2.0 and re-pin keep to b06b61f #471 are unaffectedNo version change:
versionCodestays 28 andversionNamestays 1.2.0, both already on main from #471.Summary by CodeRabbit