Skip to content

fix(scripts): clean unused imports and tuple optimizations in check_readme.py #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aoright wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(scripts): clean unused imports and tuple optimizations in check_readme.py #936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions scripts/check_readme.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@
report --results F --state F
"""
import argparse
import json
from concurrent.futures import ThreadPoolExecutor, as_completed
from datetime import date
from html.parser import HTMLParser
import http.client
import json
import re
import socket
import ssl
import sys
import threading
import time
from concurrent.futures import ThreadPoolExecutor, as_completed
from datetime import date, timezone
from html.parser import HTMLParser
from urllib.parse import urljoin, urlsplit

SCRIPT_DIR_NAME = "scripts"
Expand Down Expand Up @@ -70,7 +70,7 @@
# --------------------------------------------------------------------------

class Diagnostic:
__slots__ = ("line", "code", "severity", "message")
__slots__ = ("code", "line", "message", "severity")

def __init__(self, line, code, severity, message):
self.line = line
Expand Down Expand Up @@ -423,7 +423,7 @@ def parse_unified_diff(text):
cur_new = None
hunk_re = re.compile(r"^@@ -\d+(?:,\d+)? \+(\d+)(?:,\d+)? @@")
for raw in text.split("\n"):
if raw.startswith("+++") or raw.startswith("---"):
if raw.startswith(("+++", "---")):
continue
m = hunk_re.match(raw)
if m:
Expand Down Expand Up @@ -457,7 +457,7 @@ def cmd_check_diff(args):
if tag == "toc":
continue
if tag == "entry":
_, depth, title, url, tail, extra_urls = kind
_, _depth, title, url, _tail, extra_urls = kind
if url.startswith("http://"):
diags.append(Diagnostic(lineno, "E101", "error", f"new http:// link (use https:// if available): {url}"))
if "youtu.be" in urlsplit(url).netloc.lower():
Expand Down Expand Up @@ -588,7 +588,7 @@ def _attempt_with_fallback(url, timeout):
"""One HEAD (with GET fallback on certain statuses). Returns (status, headers, body, exc)."""
try:
status, headers, body = _single_http_call(url, "HEAD", timeout)
except Exception as exc:
except Exception:
try:
status, headers, body = _single_http_call(url, "GET", timeout)
except Exception as exc2:
Expand Down Expand Up @@ -1101,8 +1101,13 @@ def cmd_prune(args):


def render_prune_pr_body(removals, updates):
out = ["Automated fix from the weekly link-rot sweep -- only confirmed-dead "
"removals and moved-URL updates, nothing else is touched.", ""]
out = [
(
"Automated fix from the weekly link-rot sweep -- only confirmed-dead "
"removals and moved-URL updates, nothing else is touched."
),
"",
]
if removals:
out.append(f"### Removed ({len(removals)}) -- confirmed dead for 2+ consecutive weekly checks")
out.append("")
Expand Down