Honor the external definitions of CFLAGS, CXXFLAGS, and LDFLAGS#3301
Merged
Conversation
This issue arose in the context of building the Debian praat package. In Debian, some hardening options (obtained from dpkg-buildflags) must be included the CFLAGS and CXXFLAGS variables in the Makefile. This patch makes this possible by changing the assignments from ":=" to "+=". Note that only the section for Linux has been changed. Similar changes for other OS' may be appropriate.
This fixes the warning hardening-no-relro of Lintian (Debian lint package checker).
rlaboiss
changed the title
rlaboiss
changed the title
Member
Author
|
The changes in the PR have been applied to the Debian package for praat, version 6.6.30+dfsg-1, uploaded to the unstable distribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue arose in the context of building the Debian praat package. In Debian, some hardening options (obtained from
dpkg-buildflags) must be included theCFLAGSandCXXFLAGSvariables in the Makefile. This patch makes this possible by changing the assignments from:=to+=.Note that only the section for Linux has been changed. Similar changes for other OS' may be appropriate.
A second commit in this PR adds
$(LDFLAGS)to the compilation command for the praat executable.