Add build script for torch-c-dlpack-ext - #8561
Conversation
|
@cdeepali I do not have the ability to add you as a reviewer so I will just ping you here for now. |
| python3.12 -m build --wheel --no-isolation | ||
|
|
||
| echo "Built wheel:" | ||
| ls dist/torch_c_dlpack_ext-*.whl |
There was a problem hiding this comment.
Pls copy the wheel to the $CURRENT_DIR/
There was a problem hiding this comment.
Pls add basic import test for the wheel.
|
@Daniel-Schenker Sure, I have added a suggestion and comment. Pls take a look. |
Co-authored-by: Deepali <70963368+cdeepali@users.noreply.github.com>
|
@cdeepali I have applied the suggestion and addressed your comment by adding an install step and a basic import test. Please let me know if it looks good. |
|
@cdeepali Looks like its failing due to version tag issues: I had a feeling this might happen. I think the correct solution is to actually checkout the overarching version of apache-tvm-ffi that is required, and the version of torch-c-dlpack-ext is inferred from that. |
|
I have updated build_info.json to actually point to the desired apache-tvm-ffi version instead. I think this should get us in the right place. Lets see. |
|
@cdeepali Do you have any idea why it is still installing apache-tvm-ffi v0.1.5? It also is still trying to checkout "0.1.5" and erroring out. Is there some cached build_info.json that is being used or something? |
|
A fix has been added in the CI for this issue and I have tested in PR #8567. In addition to the fix in CI, a correction was needed in the build script metadata |
|
@Daniel-Schenker I can merge PR 8567 if that looks fine to you. |
|
@cdeepali Looks good to me. Thanks! |
|
Thanks @Daniel-Schenker. We have merged PR #8567 |
2 participants
Checklist
set -eoption enabled and observe success ?This PR adds the build script for torch-c-dlpack-ext package. This is an interesting one as this package is an add-on to the apache-tvm-ffi package, and therefore lives in the same GitHub repository. Additionally there is some weirdness with versions as the version of torch-c-dlpack-ext seems to be hard linked to the version of apache-tvm-ffi that is installed when building. Do let me know if there are any modifications needed to the build script or build info files.