Skip to content

Improve error recovery in sync client #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simolus3 wants to merge 2 commits into
base: main
Choose a base branch
from
+232 −322
Open

Improve error recovery in sync client #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d557ad1
Improve error recovery in sync client
simolus3 Aug 20, 2026
4c50cdb
Simplify
simolus3 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ num-derive = "0.3"
serde_json = { version = "1.0", default-features = false, features = ["alloc", "raw_value"] }
serde = { version = "1.0", default-features = false, features = ["alloc", "derive", "rc"] }
const_format = "0.2.34"
futures-lite = { version = "2.6.0", default-features = false, features = ["alloc"] }
rustc-hash = { version = "2.1", default-features = false }
thiserror = { version = "2", default-features = false }
serde_with = { version = "3.14.0", default-features = false, features = ["alloc", "macros"] }
Expand Down
15 changes: 0 additions & 15 deletions crates/core/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ use alloc::{
ffi::{CString, NulError},
string::{String, ToString},
};
use num_traits::FromPrimitive;
use powersync_sqlite_nostd::{self as sqlite, Connection, Context, ResultCode, context, sqlite3};
use thiserror::Error;

Expand Down Expand Up @@ -152,20 +151,6 @@ impl PowerSyncError {
}
}

pub fn can_retry(&self) -> bool {
match self.inner.as_ref() {
RawPowerSyncError::Sqlite(cause) => {
let base_error = ResultCode::from_i32((cause.code as i32) & 0xFF);
if base_error == Some(ResultCode::BUSY) || base_error == Some(ResultCode::LOCKED) {
true
} else {
false
}
}
_ => false,
}
}

pub fn check_sqlite3_version() -> Result<()> {
let actual_version = sqlite::libversion_number();

Expand Down
Loading
Loading