fix(tanstack-react-query): use skipToken instead of overriding enabled option#1007
Open
Chriztiaan wants to merge 4 commits into
Open
fix(tanstack-react-query): use skipToken instead of overriding enabled option#1007Chriztiaan wants to merge 4 commits into
Chriztiaan wants to merge 4 commits into
Conversation
…d option Replace the enabled: streamsHaveSynced pattern with TanStack's skipToken to preserve the user's own enabled option. Problems fixed: - User's enabled option was silently overridden by PowerSync's streamsHaveSynced - usePowerSyncQueries final useMemo was missing streamsHaveSynced in deps, returning stale values - Race condition: change listeners attached watching [] tables while resolveTables was pending, losing first-sync writes Changes: - useQuery: Conditionally pass skipToken when streams haven't synced; suspense queries always get the real queryFn - useQueries: Same skipToken approach per query entry; add streamsHaveSynced to deps - usePowerSyncQueries: Add tablesInitialized ref to rescue data lost during the []->[tables] transition; add streamsHaveSynced to return memo deps
🦋 Changeset detectedLatest commit: 173038d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credits
Note, I am taking over the work done by @msvargas in #994 to get it over the line.
Problem
PowerSync's
useQueryanduseQuerieshooks override the user'senabledoption by forcingenabled: streamsHaveSyncedat the end of the spread. Users who need conditional query control (e.g.,enabled: !!userId) lose that ability — the query always runs once streams are synced, regardless of their condition.Additionally, two secondary issues were discovered:
Stale
streamsHaveSynced— TheusePowerSyncQueriesfinaluseMemowas missingstreamsHaveSyncedin its dependency array, causing the returned value to stay stale when onlystreamsHaveSyncedchanged.Race condition on first table resolution —
resolveTablesis async. The change listener attaches watching[](empty) tables, so any write landing beforeresolveTablesresolves is silently dropped. The listener that later attaches with real tables was created after the write, so it never sees it.