ch4/ipc: fix host (cma ipc) -> device (gpu/skip ipc) copies for oversized data types - #7924
Open
nmnobre wants to merge 2 commits into
Open
ch4/ipc: fix host (cma ipc) -> device (gpu/skip ipc) copies for oversized data types#7924nmnobre wants to merge 2 commits into
nmnobre wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The aim is to fix the bcast tests when
MPIR_CVAR_CH4_CMA_ENABLE=1, which is the default on my machine:I now realise that the tests were crashing on my machine for different reasons they are crashing in the Jenkins...
I suppose the CI machines have CMA disabled?
Also, can I ask how I can control the correct execution of
alltoall, allgather_gpu, allgatherv_gpuat the bottom oftestlist.gpugiven we are settingMPIR_CVAR_ALLGATHERV_POSIX_INTRA_ALGORITHM=ipc_read(only valid on ZE)? How's Jenkins not crashing for those?