Apply idiomatic Effect patterns to SSH diagnostics#3569
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
@t3tools/ssherror classes fromData.TaggedErrortoSchema.TaggedErrorClassso they are schema-backed and serializable.JSON.parsewith a hoistedSchema.fromJsonString(Schema.Unknown)decoder.Schema.is(...)guards instead ofinstanceoffor schema errors.Why
These are small, focused idiomatic Effect improvements: schema-backed tagged errors support structured runtime checks/serialization, and Schema JSON decoding avoids ad-hoc parsing while preserving existing malformed-row filtering behavior.
UI Changes
Not applicable; no UI changes.
Checklist
Validation:
pnpm exec vp test run src/diagnostics/ProcessDiagnostics.test.tsfromapps/serverpassed (7 tests).pnpm exec vp test run src/tunnel.test.tsfrompackages/sshpassed (12 tests).pnpm exec vp test run src/ipc/methods/sshEnvironment.test.tsfromapps/desktoppassed (3 tests).pnpm exec vp checkpassed.pnpm exec vp run typecheckpassed.Note
Replace
instanceofchecks withSchema.isguards across SSH error classesSchema.TaggedErrorClasswith explicit field schemas, enabling schema-based type guards viaSchema.is.instanceofchecks withSchema.is-based guards in SSH diagnostics (sshEnvironment.ts, DesktopSshEnvironment.ts, tunnel.ts) so schema-tagged error values are recognized correctly.parseWindowsProcessRowsin ProcessDiagnostics.ts to useSchema.decodeUnknownOptioninstead of a try/catch aroundJSON.parse.Macroscope summarized 7ce32a8.