Skip to content

Remove update button from provider toast while updating#3563

Open
notkainoa wants to merge 1 commit into
pingdotgg:mainfrom
notkainoa:t3code/352a40b6
Open

Remove update button from provider toast while updating#3563
notkainoa wants to merge 1 commit into
pingdotgg:mainfrom
notkainoa:t3code/352a40b6

Conversation

@notkainoa

@notkainoa notkainoa commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

What Changed

Fix updating provider toast to remove update button while it's updating

Why

Its already updating, so we don't need an update button

Before

Screenshot 2026-06-25 at 8 49 20 PM

After

Screenshot 2026-06-25 at 8 58 01 PM

Note

Low Risk
Single-line UI toast update behavior change with no security or data impact.

Overview
Fixes the provider update launch toast so Update (and related actions) do not stay visible while the toast is in loading or success states.

updateProviderUpdateToast now passes actionProps: undefined when applying those views, so a prior prompt’s action button is cleared instead of lingering during the in-flight update.

Reviewed by Cursor Bugbot for commit f774831. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove the update button from provider toasts in loading or success state

Sets actionProps to undefined in ProviderUpdateLaunchNotification.tsx when updating a toast in the loading or success state, preventing the update button from appearing while an update is already in progress.

Macroscope summarized f774831.

- Set `actionProps` to `undefined` on provider update toasts
- Keeps the launch notification from inheriting stale action UI
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5908f525-928d-43f3-adc6-61dd88291394

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jun 26, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Single-line change that explicitly removes the action button from a toast during loading/success states. This is a minor, self-contained UI fix with clear intent and no runtime risk beyond the intended behavior.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant