Remove update button from provider toast while updating#3563
Conversation
- Set `actionProps` to `undefined` on provider update toasts - Keeps the launch notification from inheriting stale action UI
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Single-line change that explicitly removes the action button from a toast during loading/success states. This is a minor, self-contained UI fix with clear intent and no runtime risk beyond the intended behavior. You can customize Macroscope's approvability policy. Learn more. |
What Changed
Fix updating provider toast to remove update button while it's updating
Why
Its already updating, so we don't need an update button
Before
After
Note
Low Risk
Single-line UI toast update behavior change with no security or data impact.
Overview
Fixes the provider update launch toast so Update (and related actions) do not stay visible while the toast is in loading or success states.
updateProviderUpdateToastnow passesactionProps: undefinedwhen applying those views, so a prior prompt’s action button is cleared instead of lingering during the in-flight update.Reviewed by Cursor Bugbot for commit f774831. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove the update button from provider toasts in loading or success state
Sets
actionPropstoundefinedin ProviderUpdateLaunchNotification.tsx when updating a toast in theloadingorsuccessstate, preventing the update button from appearing while an update is already in progress.Macroscope summarized f774831.