Skip to content

ci: add Windows ARM desktop release support#3540

Open
morgaesis wants to merge 2 commits into
pingdotgg:mainfrom
morgaesis:windows-arm-desktop-support
Open

ci: add Windows ARM desktop release support#3540
morgaesis wants to merge 2 commits into
pingdotgg:mainfrom
morgaesis:windows-arm-desktop-support

Conversation

@morgaesis

@morgaesis morgaesis commented Jun 24, 2026

Copy link
Copy Markdown

What Changed

  • Enable the existing Windows arm64 desktop release matrix entry, using the existing Blacksmith Windows runner.
  • Enable the existing Windows updater manifest suffixing and merge steps so x64 and arm64 builds publish one canonical updater manifest per channel.

Why

I want to use T3 Code on my Windows ARM laptop. The desktop artifact tooling already supports targeting Windows arm64; the release workflow was the missing piece. Building the arm64 artifact on the existing Blacksmith Windows runner keeps the release job shape consistent while passing arm64 as the target architecture. Verified that a local build works, and the app works.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes (not applicable: no UI changes)
  • I included a video for animation/interaction changes (not applicable: no animation/interaction changes)

Note

Medium Risk
Release publish now hard-fails without matched Windows updater manifests; unsigned Windows packaging behavior changes via electron-builder defaults.

Overview
Enables Windows ARM64 desktop releases in the release workflow by adding a win/arm64 matrix job on the existing Blacksmith Windows runner (target arch arm64 while building on x64), turning on per-arch updater manifest renaming (*-win-{arch}.yml), and re-enabling the publish step that merges x64 and arm64 manifests into one channel manifest via merge-update-manifests.ts (the job fails if paired manifests are missing).

Adjusts unsigned Windows electron-builder config by no longer setting signAndEditExecutable: false, so executable resource editing stays on the default path—covered by a new createBuildConfig test for unsigned NSIS builds.

Reviewed by Cursor Bugbot for commit 91316c5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Windows ARM64 desktop release support to CI workflow

  • Adds a win arm64 variant to the desktop build matrix in release.yml using the existing Blacksmith Windows runner.
  • Produces per-arch Windows updater manifests (suffixed -win-<arch>.yml) during build, then merges arm64 and x64 manifests into a single channel manifest during publish. The publish step errors if either arch manifest is missing.
  • Removes win.signAndEditExecutable = false from unsigned Windows builds in build-desktop-artifact.ts, restoring default executable resource editing behavior.
📊 Macroscope summarized 91316c5. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bd6588d9-10ff-48b9-aa09-bd342c3aafab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 24, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 24, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR enables a new Windows ARM64 build target and changes build configuration behavior (removes signAndEditExecutable = false for unsigned builds). As a new capability enablement from a first-time contributor, human review is recommended to verify alignment with release strategy.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review June 25, 2026 00:00

Dismissing prior approval to re-evaluate 91316c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant