ci: add Windows ARM desktop release support#3540
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR enables a new Windows ARM64 build target and changes build configuration behavior (removes You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 91316c5
What Changed
Why
I want to use T3 Code on my Windows ARM laptop. The desktop artifact tooling already supports targeting Windows arm64; the release workflow was the missing piece. Building the arm64 artifact on the existing Blacksmith Windows runner keeps the release job shape consistent while passing arm64 as the target architecture. Verified that a local build works, and the app works.
Checklist
Note
Medium Risk
Release publish now hard-fails without matched Windows updater manifests; unsigned Windows packaging behavior changes via electron-builder defaults.
Overview
Enables Windows ARM64 desktop releases in the release workflow by adding a
win/arm64matrix job on the existing Blacksmith Windows runner (target archarm64while building on x64), turning on per-arch updater manifest renaming (*-win-{arch}.yml), and re-enabling the publish step that merges x64 and arm64 manifests into one channel manifest viamerge-update-manifests.ts(the job fails if paired manifests are missing).Adjusts unsigned Windows electron-builder config by no longer setting
signAndEditExecutable: false, so executable resource editing stays on the default path—covered by a newcreateBuildConfigtest for unsigned NSIS builds.Reviewed by Cursor Bugbot for commit 91316c5. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add Windows ARM64 desktop release support to CI workflow
winarm64variant to the desktop build matrix in release.yml using the existing Blacksmith Windows runner.-win-<arch>.yml) during build, then merges arm64 and x64 manifests into a single channel manifest during publish. The publish step errors if either arch manifest is missing.win.signAndEditExecutable = falsefrom unsigned Windows builds inbuild-desktop-artifact.ts, restoring default executable resource editing behavior.📊 Macroscope summarized 91316c5. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.