Fix workspace-scoped Codex skill discovery

[Quicksaver]

Summary

Fix Codex repo-local skill discovery by resolving skills for the active project/worktree cwd instead of relying on the provider status snapshot.

Codex discovers local skills relative to the cwd used for skills/list, while provider status is global to the provider instance. This PR adds a workspace-scoped provider-skills RPC, uses it in the composer and message timeline, and keeps provider probes explicit about their configured cwd so behavior does not depend on the backend process cwd.

What Changed

• Add server.listProviderSkills contracts, client-runtime query wiring, local API support, and WebSocket handler coverage.
• Add ProviderSkillsLister to serve snapshot skills for non-Codex or disabled-Codex providers while using workspace-aware Codex skills/list for enabled Codex providers.
• Start short-lived Codex app-server processes for workspace skill listing with cwd validation, Codex home preparation, timeout handling, request coalescing, TTL caching, and bounded concurrency.
• Add stable structured error handling for provider skill-list failures, including bounded details for invalid workspace roots and Codex home-preparation failures.
• Pass explicit serverConfig.cwd values into Codex, Cursor, and Grok provider status probes and ACP discovery.
• Load workspace skills lazily for the active composer workspace when the $ menu is open or the prompt already contains complete $skill references.
• Reuse the same workspace-scoped skill data for inline composer chips, pending user-input custom answers, and submitted user-message skill chips in the chat timeline.
• Key workspace skill state by environment, provider instance, and cwd; preserve same-workspace skills during pending refreshes; fall back to snapshot skills after settled empty/error lookups; and avoid carrying stale skills across workspace/provider changes.
• Surface workspace skill-listing errors in the $ menu instead of silently presenting an empty skill set.
• Add tests for provider skill-listing branches, Codex app-server cwd/timeout/termination behavior, request-cache coalescing/concurrency, provider probe cwd propagation, query-key isolation, stale pending workspace-skill state, composer skill references, and timeline skill chips.

Why

Fixes #3040.

The cwd fix is necessary but not sufficient on its own. Provider startup and status probes should use the configured server cwd, but the composer needs a workspace-specific skill query because repo-local Codex skills depend on the active project/worktree cwd.

The client state is keyed by environment/provider/cwd so skill suggestions and chips can refresh through the shared query runtime, keep useful same-workspace data visible during refreshes, and avoid showing skills from a previous workspace while a new workspace query is pending.

Validation

• pnpm exec vp check
• pnpm exec vp run typecheck
• pnpm exec vp test apps/server/src/provider/ProviderSkillsLister.test.ts
• pnpm exec vp test apps/server/src/server.test.ts -t "server.listProviderSkills"
• pnpm exec vp test apps/server/src/provider/Layers/CodexProvider.test.ts apps/server/src/provider/Layers/CursorProvider.test.ts apps/server/src/provider/Layers/GrokProvider.test.ts
• pnpm exec vp test apps/web/src/lib/providerWorkspaceSkillsState.test.ts apps/web/src/composer-editor-mentions.test.ts
• pnpm exec vp test apps/web/src/components/chat/MessagesTimeline.test.tsx

Proof

• No external proof artifacts; validation is covered by the automated checks above.

---

Note

Medium Risk
Spawns Codex app-server child processes per workspace skill request (mitigated by timeout, caching, and concurrency limits); provider probe cwd changes affect model/skill discovery behavior across workspaces.

Overview
Fixes repo-local Codex skill discovery by listing skills for the active workspace cwd instead of the global provider snapshot or the server process cwd.

Adds server.listProviderSkills (contracts, WebSocket RPC, client query) backed by ProviderSkillsLister: non-Codex or disabled Codex instances return snapshot skills; enabled Codex runs a short-lived codex app-server skills/list for the requested cwd with home prep, 15s timeout, TTL cache, coalescing, and structured ServerProviderSkillsListError payloads (via sanitizeErrorCause).

Codex, Cursor, and Grok status probes and ACP discovery now take an explicit serverConfig.cwd instead of process.cwd().

The web client loads skills through useProviderWorkspaceSkills (keyed by environment, instance, cwd) in the composer and timeline—lazy when the $ menu is open or the prompt has complete $skill tokens—with stale-workspace clearing, snapshot fallback on errors, and menu-visible failures. promptHasComposerSkillReference avoids unnecessary fetches.

^{Reviewed by Cursor Bugbot for commit c748279. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix workspace-scoped Codex skill discovery by passing cwd through provider status checks and skill listing

• Adds a listCodexProviderSkills effect in CodexProvider.ts that spawns a Codex app-server child process scoped to a caller-supplied cwd, initializes it, and requests skills/list with a 15s timeout.
• Propagates serverConfig.cwd through checkCodexProviderStatus, checkCursorProviderStatus, and checkGrokProviderStatus so provider probes run in the workspace directory instead of process.cwd().
• Introduces makeProviderSkillsLister in ProviderSkillsLister.ts — a TTL-cached (1s, cap 64), concurrency-limited (4 permits) service that validates cwd, prepares Codex shadow home, and maps failures to structured ServerProviderSkillsListError values.
• Exposes a new server.listProviderSkills WebSocket RPC (requiring AuthOrchestrationReadScope) wired to makeProviderSkillsLister in ws.ts.
• Adds a useProviderWorkspaceSkills React hook in providerWorkspaceSkillsState.ts and wires it into ChatView and ChatComposer so the skill list and composer menu reflect the active workspace rather than the global provider snapshot.

^{Macroscope summarized c748279.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 28005d40-0d16-4205-b150-0d71f4cd6be4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR introduces a new feature for workspace-scoped Codex skill discovery, including a new RPC endpoint, server-side child process spawning, and frontend state management. Despite extensive test coverage, the new capability and runtime behavior changes warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

Effect service review found one convention issue in the changed scope. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Two new ServerProviderSkillsListError constructions derive the caller-visible message from the underlying cause. Since this error flows through the server.listProviderSkills RPC error channel and into the $ menu UI, the raw underlying text leaks across a caller-visible boundary. The underlying failure is already preserved structurally via cause, so the message should be derived only from stable structural attributes.

^{Posted via Macroscope — Effect Service Conventions}