Skip to content

test: fix flaky DisaggReadSnapshot — skip background tasks during write+mergeDeltaAll (#10898) #11035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ti-chi-bot wants to merge 2 commits into
base: release-8.5
Choose a base branch
from
+7 −0
Open

test: fix flaky DisaggReadSnapshot — skip background tasks during write+mergeDeltaAll (#10898) #11035

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52134aa
test: fix flaky DisaggReadSnapshot by skipping background tasks durin…
JaySon-Huang Jun 10, 2026
379723b
Format codes
JaySon-Huang Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dbms/src/Storages/DeltaMerge/tests/gtest_segment_read_task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,13 @@ try

// stable
{
// skip_check_segment_update prevents write() from scheduling background
// flush/merge tasks, avoiding a race where background placeDeltaIndex or
// merge delta holds is_updating and causes mergeDeltaAll() to fail silently.
FailPointHelper::enableFailPoint(FailPoints::skip_check_segment_update);
auto fp_guard
= ext::make_scope_guard([]() { FailPointHelper::disableFailPoint(FailPoints::skip_check_segment_update); });

auto block = DMTestEnv::prepareSimpleWriteBlock(0, 4096, false);
store->write(*db_context, db_context->getSettingsRef(), block);
store->mergeDeltaAll(*db_context);
Expand Down