Some cleanup of CCC traits#1809
Merged
Merged
Conversation
felixpernegger
approved these changes
Jun 28, 2026
felixpernegger
left a comment
felixpernegger
left a comment
Collaborator
There was a problem hiding this comment.
(Im going to believe you all of those are really redundant)
Collaborator
Author
|
(reminder for merging: #1790 (comment)) |
Collaborator
Author
|
@felixpernegger How about unapproving and letting @JSMassmann do it? |
Collaborator
Author
|
Or I guess we can just let @JSMassmann do the merging, so it's fine as it is. |
Collaborator
|
I dont think it matters if it has been approved before |
JSMassmann
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up some CCC traits that can now be derived using T908
almost discrete + CCC => countable.