Set the timezone in the date_sun_info() example - #5740
Open
KentarouTakeda wants to merge 1 commit into
Open
Conversation
The example formats timestamps with date(), so its output followed the timezone of whoever ran it and could not be pinned down: the recorded values match no timezone on any PHP version I could test. The coordinates are Jerusalem, so the times are reported in that zone, as the polar night example below already does for Prudhoe Bay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #5721, from the audit behind #5718.
The
date_sun_info()example formatted its timestamps withdate(), so the times it printed depended on whatever timezone the reader had configured. The coordinates are in Jerusalem, and the example now sets that zone.Press Run code here and the output that appears is what this PR puts in the
<screen>: https://www.php.net/manual/en/function.date-sun-info.php