Skip to content

Remove redundant passlib pin that conflicts with libpass - #10325

Open
dpage wants to merge 1 commit into
pgadmin-org:masterfrom
dpage:fix/issue-10239-passlib-libpass-conflict
Open

Remove redundant passlib pin that conflicts with libpass#10325
dpage wants to merge 1 commit into
pgadmin-org:masterfrom
dpage:fix/issue-10239-passlib-libpass-conflict

Conversation

@dpage

@dpage dpage commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • requirements.txt pinned passlib==1.* directly, but Flask-Security-Too (>= 5.7) depends on libpass, a fork of passlib that installs its files under the same passlib/ import path.
  • Installing both packages in one environment causes a file-level collision under site-packages/passlib/; with parallel installers such as uv the result depends on install order and can leave a mixed or overwritten set of files (see issue for the exact failure modes).
  • pgAdmin's own code never imports passlib directly. The older Flask-Security-Too 5.6.x branch (used on Python 3.9) still depends on real passlib itself, so removing our direct pin doesn't change what gets installed there; on newer Python versions only libpass is installed, which resolves the conflict.

Test plan

  • Confirmed no direct passlib/libpass imports anywhere under web/pgadmin (excluding tests).
  • Confirmed via pip show that the installed Flask-Security-Too==5.8.2 requires libpass, not passlib, and nothing in the current dependency graph requires passlib.
  • Confirmed via the Flask-Security-Too 5.6.1 wheel metadata that the Python 3.9 branch still requires passlib>=1.7.4 transitively, so dropping the top-level pin doesn't remove it from that branch.
  • No functional test applicable — this is a dependency pin removal with no code changes.

Closes #10239

Summary by CodeRabbit

  • Chores
    • Removed an unused runtime dependency.

Flask-Security-Too >= 5.7 depends on libpass, a fork of passlib that
installs its files under the same passlib/ import path. Our own
unconditional passlib==1.* pin in requirements.txt therefore causes
both packages to be installed into the same site-packages/passlib/
directory, and parallel installers such as uv can end up with a
mixed or overwritten set of files depending on install order.

pgAdmin's own code never imports passlib directly, and the older
Flask-Security-Too 5.6.x branch (used on Python 3.9) already pulls in
real passlib as its own transitive dependency, so dropping our direct
pin does not change what gets installed there. On newer Python
versions, only libpass is installed, resolving the conflict.

Closes pgadmin-org#10239
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 50ae1f0b-140c-4b27-9c31-2e6b19b561c3

📥 Commits

Reviewing files that changed from the base of the PR and between 0ebefaf and ac332df.

📒 Files selected for processing (1)
  • requirements.txt
💤 Files with no reviewable changes (1)
  • requirements.txt

Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review.


Walkthrough

The runtime requirements remove the direct passlib==1.* dependency.

Changes

Dependency cleanup

Layer / File(s) Summary
Remove passlib requirement
requirements.txt
The requirements list removes the passlib==1.* entry.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ac332

This localized dependency cleanup removes a conflicting redundant pin without changing application code or introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes removing the redundant passlib pin to prevent conflicts with libpass.
Linked Issues check ✅ Passed The dependency removal directly addresses the passlib and libpass installation conflict described in issue #10239.
Out of Scope Changes check ✅ Passed The pull request changes only the dependency declaration required to address issue #10239.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgadmin4 is depending on both passlib and libpass (indirectly) which causes conflicts

1 participant