Skip to content

Relax azure-mgmt-resource pin to allow 24.0.0 - #10323

Open
dpage wants to merge 1 commit into
pgadmin-org:masterfrom
dpage:fix/issue-10247-azure-mgmt-resource-version
Open

Relax azure-mgmt-resource pin to allow 24.0.0#10323
dpage wants to merge 1 commit into
pgadmin-org:masterfrom
dpage:fix/issue-10247-azure-mgmt-resource-version

Conversation

@dpage

@dpage dpage commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Why

The azure-mgmt-resource==25.0.0 pin was introduced incidentally in 2dedb6e, a mass dependency-version bump, not because pgAdmin needed anything new from 25.0.0.

pgAdmin's own usage (web/pgadmin/misc/cloud/azure/__init__.py) is limited to:

  • from azure.mgmt.resource import ResourceManagementClient (the top-level re-export)
  • resource_client.resource_groups.list()

Both are unchanged between 24.0.0 and 25.0.0 (confirmed the import still resolves against the installed 25.0.0 package).

The exact pin blocks Linux distro packagers from shipping pgAdmin alongside Azure CLI, which still requires azure-mgmt-resource<25 (see https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/setup.py#L114).

Change

Relax the pin to azure-mgmt-resource>=24.0.0,<26.0.0, following the existing range-pin-with-rationale-comment convention already used for Flask-Security-Too in this file. This keeps 25.0.0 working for anyone who already has it installed while allowing 24.0.0.

Closes #10247

Summary by CodeRabbit

  • Chores
    • Updated Azure resource management package compatibility to support versions from 24.0.0 up to, but not including, 26.0.0.
    • Documented compatibility constraints for Azure CLI integrations.

The exact ==25.0.0 pin was an incidental side effect of a mass
dependency bump and isn't required by pgAdmin's own code: the cloud
wizard only uses the top-level ResourceManagementClient re-export and
resource_groups.list(), both unchanged between 24.0.0 and 25.0.0.
Pinning to >=24.0.0,<26.0.0 lets distro packagers keep pgAdmin
installable alongside Azure CLI, which still requires
azure-mgmt-resource<25.

Closes pgadmin-org#10247
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bfe60214-abe4-4f44-8eb7-62650bc8cf16

📥 Commits

Reviewing files that changed from the base of the PR and between 0ebefaf and 4a5b31c.

📒 Files selected for processing (1)
  • requirements.txt

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


Walkthrough

The Azure resource management dependency changes from an exact 25.0.0 pin to >=24.0.0,<26.0.0. Comments document compatibility constraints with Azure CLI.

Changes

Azure resource dependency

Layer / File(s) Summary
Update Azure resource dependency
requirements.txt
Replaces the exact azure-mgmt-resource==25.0.0 pin with >=24.0.0,<26.0.0 and adds compatibility documentation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4a5b3

The dependency range is broadened to support compatible Azure Resource Management versions without changing the documented API usage. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: asheshv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes relaxing the azure-mgmt-resource pin to allow version 24.0.0.
Linked Issues check ✅ Passed The dependency range allows azure-mgmt-resource 24.0.0 and 25.x, which fulfills issue #10247.
Out of Scope Changes check ✅ Passed The changes only adjust the azure-mgmt-resource dependency range and document the compatibility rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to decrease azure-mgmt-resource required version

1 participant