Relax azure-mgmt-resource pin to allow 24.0.0 - #10323
Conversation
The exact ==25.0.0 pin was an incidental side effect of a mass dependency bump and isn't required by pgAdmin's own code: the cloud wizard only uses the top-level ResourceManagementClient re-export and resource_groups.list(), both unchanged between 24.0.0 and 25.0.0. Pinning to >=24.0.0,<26.0.0 lets distro packagers keep pgAdmin installable alongside Azure CLI, which still requires azure-mgmt-resource<25. Closes pgadmin-org#10247
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. WalkthroughThe Azure resource management dependency changes from an exact ChangesAzure resource dependency
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The dependency range is broadened to support compatible Azure Resource Management versions without changing the documented API usage. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
The
azure-mgmt-resource==25.0.0pin was introduced incidentally in 2dedb6e, a mass dependency-version bump, not because pgAdmin needed anything new from 25.0.0.pgAdmin's own usage (
web/pgadmin/misc/cloud/azure/__init__.py) is limited to:from azure.mgmt.resource import ResourceManagementClient(the top-level re-export)resource_client.resource_groups.list()Both are unchanged between 24.0.0 and 25.0.0 (confirmed the import still resolves against the installed 25.0.0 package).
The exact pin blocks Linux distro packagers from shipping pgAdmin alongside Azure CLI, which still requires
azure-mgmt-resource<25(see https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/setup.py#L114).Change
Relax the pin to
azure-mgmt-resource>=24.0.0,<26.0.0, following the existing range-pin-with-rationale-comment convention already used forFlask-Security-Tooin this file. This keeps 25.0.0 working for anyone who already has it installed while allowing 24.0.0.Closes #10247
Summary by CodeRabbit