Skip to content

solved-issue-wp-version-feed-error#58

Open
Ankur0812 wants to merge 1 commit into
developfrom
fix/hide-wp-version-feed-error
Open

solved-issue-wp-version-feed-error#58
Ankur0812 wants to merge 1 commit into
developfrom
fix/hide-wp-version-feed-error

Conversation

@Ankur0812

Copy link
Copy Markdown
Collaborator

Description

  • Updated basic.php file for solved error
  • Other files updated for images not display and js issue, so npm related files updated.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown

Test on Playground
Test this pull request on the Playground

@Ankur0812 Ankur0812 requested a review from mehul0810 July 1, 2025 15:05
@mehul0810 mehul0810 added bug Confirmed or likely defect affecting runtime behavior, UX, compatibility, or data handling. area: compatibility WordPress, PHP, multisite, WooCommerce, theme, or plugin compatibility. area: frontend Public-facing frontend output, assets, feeds, headers, or visitor behavior. labels May 15, 2026
@mehul0810 mehul0810 added this to the 1.6.0 milestone May 15, 2026
@mehul0810 mehul0810 added priority: high Important for the next planned release or high user impact. status: in-progress Work has a branch, PR, or active release branch implementation path. risk: release-blocker Should be resolved or explicitly deferred before the target release ships. labels May 15, 2026
@mehul0810

Copy link
Copy Markdown
Collaborator

Thanks for sending this, @Ankur0812. The core idea here is valid: the Hide WP Version feed fatal was caused by registering the result of the callback instead of the callback name, and your Basic.php change points in the right direction.

Current maintainer status:

  • This PR cannot be merged as-is because it is now conflicting with develop and CI is failing.
  • The change is also much broader than the bug fix: package-lock.json, package.json, webpack.config.js, and the POT file are changed alongside the one-line PHP fix. Those build/translation changes are not needed for this bug and make the PR hard to review safely.
  • The underlying bug is currently tracked in Hide WP Version feed error #29 and was closed after release-branch validation showed the current implementation no longer reproduces the feed fatal.

Next courtesy-compliant path: if you still see this issue on current develop, please rebase the branch and narrow the PR to the minimal runtime fix plus reproduction details: WordPress/PHP versions, Perform version or branch, settings enabled, exact feed URL tested, and the fatal/error output. If the current branch no longer reproduces it, we can close this PR with thanks and credit because the accepted idea is already represented in #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: compatibility WordPress, PHP, multisite, WooCommerce, theme, or plugin compatibility. area: frontend Public-facing frontend output, assets, feeds, headers, or visitor behavior. bug Confirmed or likely defect affecting runtime behavior, UX, compatibility, or data handling. priority: high Important for the next planned release or high user impact. risk: release-blocker Should be resolved or explicitly deferred before the target release ships. status: in-progress Work has a branch, PR, or active release branch implementation path.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants