pmdaresctrl: build as DSO PMDA for local.conf, make unconditional#2646
Closed
natoscott wants to merge 1 commit into
Closed
pmdaresctrl: build as DSO PMDA for local.conf, make unconditional#2646natoscott wants to merge 1 commit into
natoscott wants to merge 1 commit into
Conversation
The resctrl PMDA has no external library dependencies and can be loaded as a DSO via local.conf, matching the pattern used by kvm, btrfs, cifs, jbd2 and other kernel agents. Created a standalone root_resctrl PMNS file for pmnsmerge, add LOCALCONF_LINE and HELPTARGETS to the build, install root_resctrl to the PMNS directories, and set pmns_source in the Install script. Also add missing resctrl entries to QA common.filter functions. This PMDA is unconditionally built and included now resolving the issue where it was unintentionally excluded from valid platforms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR moves the resctrl PMDA from a standalone RPM/Debian subpackage into the main pcp package. It removes configure-time PMDA_RESCTRL detection, RPM subpackage definitions with Obsoletes/Provides metadata for transition, updates Debian install manifests, and reworks the resctrl PMDA's build/install/PMNS to use a new root_resctrl namespace file with generated help output. Changesresctrl PMDA integration into main pcp package
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@debian/libpcp4.install`:
- Around line 21-23: The resctrl systemd unit is not currently claimed by the
Debian install manifests, so it will be omitted from the package. Update the
install manifest that owns the resctrl PMDA assets, using the existing
debian/libpcp4.install and debian/pcp-conf.install entries as the place to add
sys-fs-resctrl.mount so it gets shipped with the resctrl-related files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d573c9e3-d07a-446c-819a-c03dc3b37412
📒 Files selected for processing (15)
build/rpm/GNUmakefilebuild/rpm/pcp.spec.inbuild/rpm/redhat.specconfigureconfigure.acdebian/fixcontroldebian/libpcp4.installdebian/pcp-conf.installqa/common.filtersrc/include/builddefs.insrc/pmdas/resctrl/.gitignoresrc/pmdas/resctrl/GNUmakefilesrc/pmdas/resctrl/Installsrc/pmdas/resctrl/rootsrc/pmdas/resctrl/root_resctrl
💤 Files with no reviewable changes (4)
- src/include/builddefs.in
- build/rpm/GNUmakefile
- configure.ac
- configure
Member
Author
|
I've found a neater way to tackle this, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resctrl PMDA has no external library dependencies and can be loaded as a DSO via local.conf, matching the pattern used by kvm, btrfs, cifs, jbd2 and other kernel agents.
Created a standalone root_resctrl PMNS file for pmnsmerge, add LOCALCONF_LINE and HELPTARGETS to the build, install root_resctrl to the PMNS directories, and set pmns_source in the Install script. Also add missing resctrl entries to QA common.filter functions.
This PMDA is unconditionally built and included now resolving the issue where it was unintentionally excluded from valid platforms.