Skip to content

K8SPG-911: Fix pg_tde status reporting on standbys - #1750

Open
egegunes wants to merge 1 commit into
mainfrom
K8SPG-911-standby
Open

K8SPG-911: Fix pg_tde status reporting on standbys#1750
egegunes wants to merge 1 commit into
mainfrom
K8SPG-911-standby

Conversation

@egegunes

Copy link
Copy Markdown
Contributor

CHANGE DESCRIPTION

Problem:
Operator doesn't (and can't) run any SQL statements on standby clusters to enable and configure pg_tde. This results in status conditions related to pg_tde not appear. Consequences of this is bigger than just status reporting: enabling WAL encryption depends on these conditions being true.

Solution:
Reconcile pg_tde on standby clusters separately and observe if pg_tde is enabled and configured in database by read queries.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@JNKPercona

Copy link
Copy Markdown
Collaborator
Test Name Result Time
backup-enable-disable passed 00:00:00
builtin-extensions passed 00:06:57
custom-extensions failure 00:06:52
cert-manager-tls passed 00:00:00
cert-management-policy failure 00:07:29
custom-envs passed 00:00:00
custom-tls passed 00:00:00
database-init-sql passed 00:00:00
demand-backup passed 00:00:00
demand-backup-offline-snapshot passed 00:00:00
dynamic-configuration passed 00:00:00
extra-volumes passed 00:00:00
finalizers passed 00:00:00
init-deploy passed 00:00:00
huge-pages passed 00:00:00
major-upgrade-14-to-15 passed 00:00:00
major-upgrade-15-to-16 passed 00:00:00
major-upgrade-16-to-17 passed 00:00:00
major-upgrade-17-to-18 passed 00:00:00
ldap passed 00:00:00
ldap-tls passed 00:00:00
logcollection passed 00:00:00
monitoring passed 00:00:00
one-pod passed 00:00:00
repo-host-autogrow passed 00:00:00
operator-self-healing passed 00:00:00
pgbouncer passed 00:00:00
pg-tde passed 00:00:00
pg-tde-wal-encrypt passed 00:00:00
pitr passed 00:00:00
scaling passed 00:00:00
scheduled-backup passed 00:00:00
self-healing passed 00:00:00
sidecars passed 00:00:00
standby-pgbackrest passed 00:00:00
standby-streaming passed 00:00:00
start-from-backup passed 00:00:00
tablespaces passed 00:00:00
telemetry-transfer passed 00:00:00
upgrade-consistency passed 00:00:00
upgrade-minor passed 00:00:00
users passed 00:00:00
migration-from-crunchy-standby passed 00:00:00
migration-from-crunchy-pv passed 00:00:00
migration-from-crunchy-backup-restore passed 00:00:00
Summary Value
Tests Run 45/45
Job Duration 00:41:50
Total Test Time 00:21:18

commit: ee3efcc
image: perconalab/percona-postgresql-operator:PR-1750-ee3efcca4

"the condition should name the Secret that could not be read")
assert.Equal(t, patched, 1,
"the failure condition is useless unless it is written to the API")
assertEvent(t, r.Recorder, "PGTDEVaultProviderChangeFailed")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the deletion intended? I didn't find the logic that affects the event and the test still passes with this line added back

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i deleted it by mistake, will restore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants