K8SPG-911: Fix pg_tde status reporting on standbys - #1750
Open
egegunes wants to merge 1 commit into
Open
Conversation
egegunes
requested review from
gkech,
hors,
mayankshah1607,
nmarukovich,
oksana-grishchenko and
pooknull
as code owners
August 12, 2026 18:51
Collaborator
commit: ee3efcc |
oksana-grishchenko
approved these changes
Aug 13, 2026
| "the condition should name the Secret that could not be read") | ||
| assert.Equal(t, patched, 1, | ||
| "the failure condition is useless unless it is written to the API") | ||
| assertEvent(t, r.Recorder, "PGTDEVaultProviderChangeFailed") |
Contributor
There was a problem hiding this comment.
Is the deletion intended? I didn't find the logic that affects the event and the test still passes with this line added back
Contributor
Author
There was a problem hiding this comment.
i deleted it by mistake, will restore
mayankshah1607
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Operator doesn't (and can't) run any SQL statements on standby clusters to enable and configure pg_tde. This results in status conditions related to pg_tde not appear. Consequences of this is bigger than just status reporting: enabling WAL encryption depends on these conditions being true.
Solution:
Reconcile pg_tde on standby clusters separately and observe if pg_tde is enabled and configured in database by read queries.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability