Skip to content

K8SPG-1114: Automate deploying logical replicas #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egegunes merged 12 commits into from
Aug 18, 2026
Merged

K8SPG-1114: Automate deploying logical replicas #1747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7a4b4d3
K8SPG-1114: Automate deploying logical replicas
egegunes Aug 5, 2026
6ff1a50
suspend logical replicas when cluster is paused
egegunes Aug 17, 2026
05b6430
remove primary ready condition if all logical replicas are removed
egegunes Aug 17, 2026
f2ef6d1
update cr example to empty databases
egegunes Aug 17, 2026
823e938
bootstrap logical replicas one by one
egegunes Aug 17, 2026
ae64bfb
add uniqueness validation for logical replicas and databases
egegunes Aug 17, 2026
bb3bc10
Merge branch 'main' into K8SPG-1114
egegunes Aug 17, 2026
4f28e8d
address george
egegunes Aug 17, 2026
31d5852
Merge branch 'main' into K8SPG-1114
hors Aug 17, 2026
a31be23
Merge branch 'main' into K8SPG-1114
hors Aug 17, 2026
c30b6a4
fix envtest and linters
egegunes Aug 18, 2026
e584bf2
fix golangci-lint
egegunes Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ go-fix: ## Run go fix on all packages

.PHONY: generate
generate: ## Generate crd, crd-docs, deepcopy functions, and rbac
$(MAKE) go-fix
$(MAKE) generate-all
$(MAKE) go-fix

@gkech gkech Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we moved this here? the idea was to fix code first and then generate all based on the new code. for example it may affect godoc annotations that affect generation

@egegunes egegunes Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagine you have conflicts in zz_generated.deepcopy.go after a merge or rebase which happens fairly often. running go fix before go generate makes it impossible to fix conflicts by generating the code. i hit this issue and that's why moved to the end


.PHONY: generate-all
generate-all: kustomize
Expand Down
681 changes: 681 additions & 0 deletions build/crd/percona/generated/pgv2.percona.com_perconapgclusters.yaml
View file
Open in desktop

Large diffs are not rendered by default.

681 changes: 681 additions & 0 deletions config/crd/bases/pgv2.percona.com_perconapgclusters.yaml
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions config/crd/bases/upstream.pgv2.percona.com_postgresclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10819,6 +10819,18 @@ spec:
x-kubernetes-list-map-keys:
- name
x-kubernetes-list-type: map
logicalReplicas:
items:
properties:
name:
type: string
required:
- name
type: object
type: array
x-kubernetes-list-map-keys:
- name
x-kubernetes-list-type: map
metadata:
properties:
annotations:
Expand Down
21 changes: 16 additions & 5 deletions config/rbac/cluster/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,15 @@ rules:
- ''
resources:
- configmaps
- pods
- secrets
- serviceaccounts
- persistentvolumeclaims
- services
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ''
Expand Down Expand Up @@ -49,27 +48,39 @@ rules:
- apiGroups:
- ''
resources:
- persistentvolumeclaims
- pods
- secrets
- serviceaccounts
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments
- replicasets
verbs:
- create
- delete
- get
- list
- patch
- watch
- apiGroups:
- apps
resources:
- statefulsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- batch
Expand Down
21 changes: 16 additions & 5 deletions config/rbac/namespace/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,15 @@ rules:
- ''
resources:
- configmaps
- pods
- secrets
- serviceaccounts
- persistentvolumeclaims
- services
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- ''
Expand Down Expand Up @@ -49,27 +48,39 @@ rules:
- apiGroups:
- ''
resources:
- persistentvolumeclaims
- pods
- secrets
- serviceaccounts
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- deployments
- replicasets
verbs:
- create
- delete
- get
- list
- patch
- watch
- apiGroups:
- apps
resources:
- statefulsets
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- batch
Expand Down
Loading
Loading