Skip to content

Resume v2 polling on transient directory errors#1671

Draft
bc1cindy wants to merge 7 commits into
payjoin:masterfrom
bc1cindy:transient-poll-retry
Draft

Resume v2 polling on transient directory errors#1671
bc1cindy wants to merge 7 commits into
payjoin:masterfrom
bc1cindy:transient-poll-retry

Conversation

@bc1cindy

@bc1cindy bc1cindy commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

v2 poll loops resume on a transient (5xx) directory error instead of aborting the session, honoring RejectTransient "resume from current state" contract; fatal (4xx) still terminates.

stacked on #1658, do not merge first. The first 4 commits here belong to #1658 and drop out on rebase once it merges.

this PR's own 3 commits are viewable cleanly here: bc1cindy:transient-poll-retry

part of #1670

bc1cindy added 7 commits June 19, 2026 17:32
Shared so all clients converge on one rate; a divergent rate is itself
a fingerprint.
GET now peeks instead of blocking. The v2 waitmap it no longer uses is
still woven into the Db trait, post_v2, and tests, so removal is a follow-up.
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27992226464

Coverage increased (+0.1%) to 85.34%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 18 uncovered changes across 4 files (237 of 255 lines covered, 92.94%).
  • 21 coverage regressions across 1 file.

Uncovered Changes

File Changed Covered %
payjoin-cli/src/app/v2/mod.rs 61 49 80.33%
payjoin-mailroom/src/directory.rs 23 19 82.61%
payjoin-mailroom/src/db/mod.rs 22 21 95.45%
payjoin/src/core/schedule.rs 37 36 97.3%
Total (8 files) 255 237 92.94%

Coverage Regressions

21 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
payjoin-mailroom/src/db/mod.rs 21 71.95%

Coverage Stats

Coverage Status
Relevant Lines: 14973
Covered Lines: 12778
Line Coverage: 85.34%
Coverage Strength: 380.65 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants