Fix non-ASCII heading anchors not navigating from links - #64
Merged
Conversation
goldmark's default ID generator skips multi-byte UTF-8 characters, causing Japanese/non-ASCII headings to fall back to "heading" as the id. Replace it with a GFM-compatible implementation that preserves Unicode letters and digits so links like [text](#ヘディング) work. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Summary
IDsgenerator skips multi-byte UTF-8 characters, so headings like# ヘディングgetid="heading"(fallback) instead ofid="ヘディング"gfmIDsininternal/markdown/headingid.go: a GFM-compatible ID generator that preserves Unicode letters/digits (Japanese, Chinese, etc.) and lowercases ASCII lettersparser.NewContext(parser.WithIDs(newGFMIDs()))inConvert()Test plan
go test ./internal/markdown/...— newTestConvert_NonASCIIHeadingAnchorcovers Japanese-only, mixed, and ASCII-only headings[ヘディング](#ヘディング)and# ヘディングand verify the link navigates correctly in the browser🤖 Generated with Claude Code