Fix print CSS partially applied due to external stylesheet timing - #60
Merged
Conversation
Wait for all <link rel="stylesheet"> elements to finish loading before calling window.print(). This prevents the theme CSS (dynamically switched via localStorage on page load) from being missing in the print preview. A 3-second timeout ensures the print dialog is never blocked indefinitely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
Summary
printPage()now waits for all<link rel="stylesheet">elements to finish loading before callingwindow.print().sheetaccess via CORS are skipped gracefullyRoot Cause
On page load,
switchTheme()is called with the theme fromlocalStorage, which changeshrefon the theme<link>element and triggers a new HTTP request. Callingwindow.print()before this request completes results in a print preview without theme CSS applied.Test plan
🤖 Generated with Claude Code