Fix math block rendering broken by CRLF line endings - #52
Merged
Conversation
Normalize CRLF to LF at the start of Convert so PreprocessMathBlocks and goldmark receive consistent line endings. Without this, the trailing \r left on each line caused the closing $$ detector to misidentify content, breaking display math rendering for Windows-style files. Add regression test in convert_test.go. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Summary
\r\n) to LF (\n) at the start ofConvertsoPreprocessMathBlocksand goldmark receive consistent line endingsTestConvert_CRLFMathBlockinconvert_test.goRoot cause
PreprocessMathBlockssplits on\n, leaving a trailing\ron each line with CRLF input.bytes.TrimRight(body, " \t")does not strip\r, so the closing$$\rline was misdetected as having content$before the delimiter, corrupting the math block structure.Test plan
go test ./internal/markdown/... -run TestConvert_CRLFMathBlockpassesgo test ./...)make buildsucceeds🤖 Generated with Claude Code