Fix SVG code blocks with blank lines not rendering - #46
Merged
Conversation
Blank lines inside SVG content caused goldmark to split the HTML block (CommonMark HTML block type 6 terminates at blank lines), resulting in broken SVG rendering. Strip blank lines from SVG content before embedding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #45
PreprocessCodeBlocksbefore embedding as raw HTMLTest plan
TestPreprocessCodeBlocks_SVGWithBlankLines— verifies blank lines are removed from outputTestConvert_SVGWithBlankLines— verifies SVG survives full goldmark conversion without being escaped🤖 Generated with Claude Code