nodes: stop tracking elevator dirty state - #599
Open
JimmyZheng-ZJU wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops renderer-driven elevator nodes from entering the shared
dirtyNodesrebuild queue. Elevators have nodef.geometry,capabilities.floorPlaced, or legacy dirty consumer, so scene-load and mutation marks were never cleared and the performance HUD remained atDIRTY 1 (1 elevator). The definition now uses the existingdirtyTracking: falsecontract, with a regression test covering both the declaration and scene-load-stylemarkDirtybehavior.How to test
bun test packages/core/src/store/use-scene-dirty-tracking.test.ts packages/core/src/store/use-scene-elevator-migration.test.ts packages/core/src/systems/elevator packages/nodes/src/elevator/definition.test.ts; expect 17 passing tests.bun test packages/nodes/src; expect 946 passing tests, 1 skipped, and 0 failures.bunx turbo run build --filter=@pascal-app/nodes...andbun run check; expect the Core, Viewer, and Nodes builds plus Biome checks to pass.Screenshots / screen recording
N/A — internal dirty-queue scheduling fix; no editor UI or elevator geometry output changes.
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
Narrow change to dirty-queue bookkeeping for one node kind; no auth, data, or elevator geometry/rendering logic changes.
Overview
Sets
dirtyTracking: falseon the elevator node definition so scene-load and mutationmarkDirtycalls no longer leave elevators in the shareddirtyNodesqueue.Elevators have no geometry rebuild or other dirty consumer that clears those marks, which previously kept the perf HUD at DIRTY 1, blocked idle-frame detection (elevator
def.systemcounts as pending work), and skewed post-processing scheduling. A newdefinition.test.tsasserts the flag and that registeredmarkDirtydoes not retain the elevator id.Reviewed by Cursor Bugbot for commit 39c59ac. Bugbot is set up for automated code reviews on this repo. Configure here.