Skip to content

deprecate: GET /role api #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parmesant wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −5
Open

deprecate: GET /role api #1758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/handlers/http/modal/ingest_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,6 @@ impl IngestServer {
// get the role webscope
pub fn get_user_role_webscope() -> Scope {
web::scope("/role")
// GET Role List
.service(web::resource("").route(web::get().to(role::list).authorize(Action::ListRole)))
.service(
// PUT and GET Default Role
web::resource("/default")
Expand Down
2 changes: 0 additions & 2 deletions src/handlers/http/modal/query_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,6 @@ impl QueryServer {
// get the role webscope
pub fn get_user_role_webscope() -> Scope {
web::scope("/role")
// GET Role List
.service(resource("").route(web::get().to(role::list).authorize(Action::ListRole)))
.service(
// PUT and GET Default Role
resource("/default")
Expand Down
2 changes: 1 addition & 1 deletion src/handlers/http/role.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ pub async fn get(req: HttpRequest, name: web::Path<String>) -> Result<impl Respo
Ok(web::Json(role))
}

// Handler for GET /api/v1/role
// Handler for GET /api/v1/roles
// Fetch all roles in the system
pub async fn list(req: HttpRequest) -> Result<impl Responder, RoleError> {
let tenant_id = get_tenant_id_from_request(&req);
Expand Down
Loading