Skip to content

chore(make): drop the Android shell parity check #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TarikGul wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(make): drop the Android shell parity check #322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad26f83
chore(make): drop the Android shell parity check
TarikGul Jul 29, 2026
a9d7279
chore(make): keep headless and install declared .PHONY
TarikGul Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Run `make help` for the list of targets.

.DEFAULT_GOAL := help
.PHONY: help setup build codegen test check clean playground wasm wasm-crypto-test uniffi uniffi-kotlin android-jni android-publish-local check-android-parity dotli-link dev dev-bootstrap dev-link-check e2e-dotli headless install matrix explorer
.PHONY: help setup build codegen test check clean playground wasm wasm-crypto-test uniffi uniffi-kotlin android-jni android-publish-local dotli-link dev dev-bootstrap dev-link-check e2e-dotli headless install matrix explorer

CARGO ?= cargo
TRUAPI_PKG := js/packages/truapi
Expand Down Expand Up @@ -137,21 +137,6 @@ check: ## Full verification suite (build, fmt, clippy, test, TS tests, playgroun
cd $(JS_PACKAGES)/truapi-host && npm install --no-fund --no-audit && npm test
cd $(PLAYGROUND) && yarn build && yarn lint

ANDROID_SHELL := android/truapi-host/src/main/kotlin/io/parity/truapi/TrUAPIHost.kt
ANDROID_SHELL_VENDORED := hosts/android/bindings/truapi-host/src/main/kotlin/io/parity/truapi/TrUAPIHost.kt

check-android-parity: ## Verify the canonical android/truapi-host shell matches the copy vendored in the app (hosts/android). Skips if the submodule is not initialized.
@if [ ! -f "$(ANDROID_SHELL_VENDORED)" ]; then \
echo "Skipping android parity check: hosts/android not initialized (run 'git submodule update --init hosts/android')."; \
elif diff -q "$(ANDROID_SHELL)" "$(ANDROID_SHELL_VENDORED)" >/dev/null; then \
echo "android/truapi-host shell matches the vendored app copy."; \
else \
echo "ERROR: $(ANDROID_SHELL) has drifted from $(ANDROID_SHELL_VENDORED)."; \
echo "The host adapter shell is duplicated in truapi and the app; keep them in sync."; \
diff "$(ANDROID_SHELL)" "$(ANDROID_SHELL_VENDORED)" || true; \
exit 1; \
fi

clean: ## Remove local build/test artifacts without deleting dependencies.
cargo clean
rm -rf \
Expand Down