fix(playground): report prerequisite skips neutrally - #316
Open
replghost wants to merge 1 commit into
Open
Conversation
replghost
force-pushed
the
epoca-diagnosis
branch
2 times, most recently
from
July 25, 2026 16:52
d61f19d to
6456e54
Compare
replghost
changed the title
replghost
force-pushed
the
epoca-diagnosis
branch
from
July 25, 2026 16:57
6456e54 to
ad81e7e
Compare
replghost
changed the title
replghost
force-pushed
the
epoca-diagnosis
branch
from
July 25, 2026 16:59
ad81e7e to
42d2bc7
Compare
replghost
force-pushed
the
epoca-diagnosis
branch
from
July 25, 2026 17:00
42d2bc7 to
b9adba9
Compare
replghost
enabled auto-merge
July 25, 2026 17:05
pgherveou
reviewed
Jul 27, 2026
| const SKIPPED_METHODS = new Set(["Account/create_account_proof"]); | ||
| // Individual methods skipped when Diagnosis cannot establish their prerequisite. | ||
| const SKIPPED_REASON: Record<string, string> = { | ||
| "Account/create_account_proof": "host surface intentionally deferred", |
Collaborator
There was a problem hiding this comment.
this one should work now, we should not skip it.
pgherveou
reviewed
Jul 27, 2026
| "Account/create_account_proof": "host surface intentionally deferred", | ||
| "Chain/stop_transaction": | ||
| "requires an operation id from a live transaction broadcast", | ||
| }; |
Collaborator
There was a problem hiding this comment.
do we need this since you fix the test in #318
pgherveou
approved these changes
Jul 27, 2026
pgherveou
left a comment
pgherveou
left a comment
Collaborator
There was a problem hiding this comment.
after reviewing comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Diagnosis intentionally skips services hosts have not wired and methods whose prerequisites it cannot establish. The UI/report converted every skip into a failure/❌, creating false compatibility failures.
Chain/stop_transactionexposed the problem: its manual example requires a live operation id, while Diagnosis only has a hard-coded placeholder.Fix
Chain/stop_transactionskipped with its exact live-operation prerequisiteskippedthrough the Diagnosis UI and markdown reportnull), not supportedThis does not turn unsupported hosts green: genuine runtime errors remain ❌ and the matrix only records actual ✅/❌ measurements.
Verification
cd playground && yarn buildcd playground && yarn lint34 success · 9 failed · 21 skipped; the report emitted ⏭ for deferred services and transaction stop, while nine real environment/policy failures remained ❌.