Skip to content

Code coverage#529

Draft
kvpanch wants to merge 20 commits into
mainfrom
kvpanch/code_coverage
Draft

Code coverage#529
kvpanch wants to merge 20 commits into
mainfrom
kvpanch/code_coverage

Conversation

@kvpanch

@kvpanch kvpanch commented May 26, 2026

Copy link
Copy Markdown
Contributor

Adds make coverage (cargo-llvm-cov over the full workspace including revive-llvm-builder), a new "Code coverage" book chapter that links to the locally-collected report with the commit + UTC timestamp stamped in, and a PR workflow that publishes the report to gh-pages when the measure code coverage label is applied.

Adds `make coverage` (cargo-llvm-cov over the full workspace including
revive-llvm-builder), a new "Code coverage" book chapter that links to the
locally-collected report with the commit + UTC timestamp stamped in, and a
PR workflow that publishes the report to gh-pages when the
`measure code coverage` label is applied.
@kvpanch kvpanch requested review from elle-j and xermicus May 26, 2026 19:22
@kvpanch kvpanch added the measure code coverage measure code coverage for the PR label May 26, 2026

@xermicus xermicus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick first round

Comment thread Makefile Outdated
MDBOOK_VERSION = 0.5.1

install-mdbook:
@mdbook --version 2>/dev/null | grep -qx "mdbook v$(MDBOOK_VERSION)" \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? The cargo install is essentially a no-op if the installed version is already present

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will drop it.

Comment thread Makefile Outdated
Comment thread revive-differential-tests

@xermicus xermicus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get these fixes in. @kvpanch can you please resolve the merge conflicts?

kvpanch and others added 9 commits June 26, 2026 10:20
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <bigcyrill@hotmail.com>
Signed-off-by: xermicus <bigcyrill@hotmail.com>
@xermicus

xermicus commented Jul 9, 2026

Copy link
Copy Markdown
Member

Pushed to the branch since @kvpanch is OOO.

Eventually I scrapped the book approach. It's too brittle. I vote: Merge this now as is with just the fixes, and think a bit more about where the coverage report should live. Or if we should overhaul the approach of checking in the build docs/ altogether (though I like the simple and stupid approach).

@elle-j elle-j left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's preferably hold off with this merge atm, found some security issues and other fixes that I'll address as a PR targeting this branch.

@elle-j elle-j marked this pull request as draft July 10, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

measure code coverage measure code coverage for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants