fix: accept the test dotNS TLD in product identifiers - #465
Merged
Conversation
Networks that declare `test` as their dotNS TLD register product names under it, so `.test` names have to clear product-identifier validation and classify as dotNS navigation rather than falling through to external.
valentinfernandez1
approved these changes
Aug 20, 2026
TarikGul
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOTNS_TLDScoversdot,paseoandtest, so a.testname is an acceptedproduct identifier and classifies as dotNS navigation.
Each network declares its own dotNS TLD, and PreviewNet and Gaming Net register
under
.test(brevity-chain'sDotnsConfig::gamingnet()setsbrowse_domain: Some("browse.test")). Withtestmissing from the set,parse_navigate("browse.test")returnsExternal, sobrevity-ffi'sclassify_host_navigationroutes the name toOpenExternalUrland the productopens in a browser instead of loading as a product SPA.
normalize_product_identifierrejects the same name.Downstream identity is unaffected: hosts canonicalize the per-network spelling
to the
.dotidentity before it reaches a cache, archive or derivation key, thesame way they already handle
.paseonames since #369.Tests:
product_context_validation_cases("Browse.TEST"→browse.test) andparse_navigate_cases(bare, mixed-case-with-path,polkadot://; port anduserinfo forms stay rejected). Both fail on
main.example.comanddotli.dottyremain rejected;mytestapp.dot.liremains external.Follow-up worth considering: taking the TLD set from host configuration instead
of a compile-time constant, so it tracks the network rather than core releases.