Feat/ios motiontag sdk 7#8
Merged
Merged
Conversation
7.0.0 is a pure-Swift, fully @MainActor-isolated module with no Objective-C surface. It ships no MotionTag.h / MotionTagSDK.h, so MotionTagModule.mm's `#import <MotionTagSDK/MotionTagSDK.h>` no longer resolves; the SDK is reached only through the Swift shim, whose generated header omits the now non-@objc MotionTagDelegate conformance. Because the delegate protocol is @mainactor and refines Sendable, MotionTagDelegateImpl must be main-actor isolated, so every @objc entry point is now called from the main queue. isTrackingActive stops resolving synchronously on the JS thread; JS already awaited a Promise, so the observable contract is unchanged. `MotionTag` is not class-constrained, so the cached `motionTag` existential has to be a `var` for property writes to type-check. The conformer is a reference type, so writes still reach the shared instance. processBackgroundSessionEvents(with:) lost its completion-handler overload. The async form is exposed as the primary shim; the completion-handler shim is kept because ExpoAppDelegate declares only that spelling, in Swift, and Swift synthesises the async spelling only for Objective-C declarations. Both public signatures are unchanged, so host apps need no source change. Note the vendor's prose guide is stale on two points the compiled interface settles: the label is `launchOptions:`, not `launchOption:`, and its `let motionTag: MotionTag` snippet does not compile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0124GwP2xm3zYhoUiiSKWbeA
The injected override never called super, so ExpoAppDelegate's subscriber fan-out was skipped entirely. That was masked under SDK v6, where the SDK received the completion handler and invoked it only for its own sessions. Since v7 the SDK no longer takes the handler, so our shim invokes it for every identifier. Combined with a restored super call that would fire a background completion handler twice, so the handler is now passed to super instead: MotionTag drains its session first, then Expo's subscribers run and invoke the handler exactly once. Also switch the bare-RN README snippet to the async override, which lets a host that owns other background URL sessions await each in turn and leaves UIKit to invoke the handler once. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0124GwP2xm3zYhoUiiSKWbeA
These were stubbed out as "not supported on iOS (MotionTag SDK v6)", but v6.5.0 already exposed userToken, wifiOnlyDataTransfer and clearData on its MotionTag protocol. The comments were wrong, not the SDK; the 7.0.0 migration only made that visible. getUserToken now resolves the stored JWT instead of null, getWifiOnlyDataTransfer reports the real flag instead of false, and setWifiOnlyDataTransfer / clearData resolve instead of rejecting UNSUPPORTED. clearData's record count is discarded: the TS spec declares Promise<void> and Android resolves null. isPowerSaveModeEnabled and isBatteryOptimizationsEnabled stay Android-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0124GwP2xm3zYhoUiiSKWbeA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.