[Draft] Literal Include#61
Conversation
Quick draft w/ Cursor on include support.
| facility_included_file.write_text(facility_included_content) | ||
| facility_nested_file.write_text(facility_nested_content) | ||
|
|
||
| data = pals.Lattice.from_file(main_file) |
There was a problem hiding this comment.
What was the intention here? Why does this go through Lattice.from_file as opposed to going through functions.load_file_to_dict as below (which would work here too - tested locally)? Could you comment on whether you wanted to expand the Lattice.from_file function but haven't gotten to implement the feature in the PR yet? I think I'm missing some context, inteded use case, and current PR progress, to start working on completing this PR.
There was a problem hiding this comment.
Do you have any info to share about the questions in my previous comment?
There was a problem hiding this comment.
Ah I thought we discussed this in person 2 weeks ago :)
from_file is the primary user-facing API users shall use, so this exercises that API.
Using both here and below just spreads the API surface coverage with minimal duplication.
2 participants
Quick draft w/ Cursor on include support.