Skip to content

AI junk - #1428

Closed
princ0301 wants to merge 1 commit into
pallets-eco:mainfrom
princ0301:fix-1402-include-bindkey-in-query-recording
Closed

AI junk#1428
princ0301 wants to merge 1 commit into
pallets-eco:mainfrom
princ0301:fix-1402-include-bindkey-in-query-recording

Conversation

@princ0301

Copy link
Copy Markdown

Fixes #1402

Summary

The _QueryInfo dataclass and the _record_end function in record_queries.py were missing the logic to handle bind_key. I've updated the dataclass to include the bind_key attribute and modified _record_end to determine and record the bind_key for each query. A regression test is also added to tests/test_engine.py to verify that the bind_key is correctly recorded.

Validation

Tests passing after 4 attempt(s).

tests/test_model_name.py ............................................... [ 57%]
.....................................                                    [ 65%]
tests/test_pagination.py ............................................... [ 75%]
..............................                                           [ 82%]
tests/test_record_queries.py .                                           [ 82%]
tests/test_session.py ..............................                     [ 89%]
tests/test_table_bind.py ....................                            [ 93%]
tests/test_track_modifications.py .....                                  [ 94%]
tests/test_view_query.py .........................                       [100%]
======================== 460 passed, 2 skipped in 3.97s ========================

@davidism davidism changed the title fix: Include bind_key in query recording (#1402) AI junk May 24, 2026
@davidism davidism closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Include bind_key in query recording

2 participants