Clean: use 'msvc' requirement to detect MSVC paths - #49
Open
BraveChicken1 wants to merge 1 commit into
Open
Conversation
BraveChicken1
added
the
next Packit version
BraveChicken1
force-pushed
the
clean/msvc
branch
2 times, most recently
from
July 25, 2026 09:57
385c7fc to
d9b4e21
Compare
BraveChicken1
force-pushed
the
clean/msvc
branch
from
August 12, 2026 12:22
d9b4e21 to
77aecfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans the core repository by using the new
build_requirementsandtest_requirementsfields to initialize MSVC.makenow also uses a explicit initialization of the MSVC environment, because the automatic detection inbuild_w32.batdoes not always work reliably, as noted in pack-it/packit#126.Requires the next Packit version, as the feature was added in pack-it/packit#121.