Post-#748 gap sweep: confirmed-block coverage, doc contradictions, changelog#749
Merged
Conversation
…ontradictions, changelog Tests: the #381 confirmed-payouts block had no component coverage at all (introduced by #739, stacked on by #748, untested both times) — one render test now pins both tabs, the summary-key wiring, the estimates-then- confirmed order, and the disabled default. The build_state payouts test gains the gate-agreement assertion (timeline and card summaries read the same flags in the same request). Two windowed-math tests deleted — they re-derived what TestConfirmedPayoutsSummary already proves, against the test-once tier model. Docs: the mine-cart section claimed the chart shows everything the train shows — false for the Tari gem coin, which is deliberately chart-exclusive; both sections now cross-reference the split honestly. The "no chart reads them yet" claim narrowed to disk_growth (blocks feeds the train, xvb_history the donation overlay). CHANGELOG gains the missing #748 entries. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-release sweep of merged develop (#739 + #748 interaction seams), per the release checklist.
Tests
build_statepayouts test gains a gate-agreement assertion: the mine-cart timeline and the card summaries read the same confirmation flags in the same request — they can never disagree.TestConfirmedPayoutsSummaryalready proves (test-once tier model; the plumbing tests stay).Docs
disk_growth(blocksfeeds the train,xvb_historythe donation overlay — both claims had gone stale).[Unreleased]gains the missing Dashboard UX round: standardized calculator metrics, mine cart train, panel cleanup #748 entries (required before the next cut).Verification: frontend 263/263 · dashboard pytest 96.85% coverage · lint + docs-voice clean.
🤖 Generated with Claude Code