PoC: move some e2e tests to Vitest browser mode #3287
Draft
david-crespo wants to merge 7 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
vitest-browser
branch
from
2a399f5 to
b7b4184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a lot of e2e tests that are really more like UI unit tests, and they seem to be quite bit faster this way (2 seconds for three browsers vs. 8 seconds for one browser), presumably because Vitest doesn't spin up a whole new page for every test. In addition to the speed improvement, it's also nice to have the unit-test-like parts of our code actually written as such, instead of being buried in tests for pages that happen to have that component on them.
https://vitest.dev/guide/browser/why.html