Generate message length and cycle time consts from DBC attributes#176
Open
felixvanoost wants to merge 4 commits into
Open
Generate message length and cycle time consts from DBC attributes#176felixvanoost wants to merge 4 commits into
felixvanoost wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
for more information, see https://pre-commit.ci
felixvanoost
force-pushed
the
parse-message-cycle-time-attribute
branch
from
829730a to
cee3a5c
Compare
felixvanoost
changed the title
felixvanoost
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates the following new constants per message:
MESSAGE_LENGTHcontaining the length in bytes. This avoids the overhead of usingraw().len()orembedded_can::Frame::dlc()and makes the length known at compile-time.MESSAGE_CYCLE_TIMEcontaining the value from the correspondingGenMsgCycleTimeDBC attribute when it is present.This PR should be stacked on top of #175 as it reuses the
message_attrhelper method.