Port JL advanced-physics compatibility to rift_O4d - #175
Open
oshaughnessy-junior wants to merge 6 commits into
Open
Port JL advanced-physics compatibility to rift_O4d#175oshaughnessy-junior wants to merge 6 commits into
oshaughnessy-junior wants to merge 6 commits into
Conversation
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
August 20, 2026 16:04 — with
GitHub Actions
Active
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
August 20, 2026 16:09 — with
GitHub Actions
Active
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
August 20, 2026 16:11 — with
GitHub Actions
Active
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
August 20, 2026 16:19 — with
GitHub Actions
Active
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
August 20, 2026 18:32 — with
GitHub Actions
Active
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
August 20, 2026 18:45 — with
GitHub Actions
Active
oshaughnessy-junior
marked this pull request as ready for review
August 20, 2026 19:27
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
August 20, 2026 19:27 — with
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a conflict-resolved port of the core advanced-physics functionality from
oshaughn/rift_O4d_JL(355c3f9f) ontooshaughnessy-junior/rift_O4d(4c1da52c). It preserves the newerrift_O4dcalibration, interpolation, GPU, and pipeline behavior while adding:a6cand hyperbolicE0/p_phi0sampling, output, grid filtering, and waveform handling;auto(default),dali,default, andlegacyprofiles, safe schema preflight, explicit overrides, and runtime fingerprinting;The old
integrate_likelihood_extrinsic_batchmode_errorfull-script duplicate is intentionally not ported: it had diverged into a maintenance fork and does not add a distinct supported entry point.Compatibility behavior
autois the default. Known DALI interfaces receive their string-valued enum/boolean schema; other or future-looking interfaces conservatively receive the established default schema. An operator can pinRIFT_TEOBRESUMS_PROFILE=default|dali|legacy. The first schema is probed in a subprocess, preventing an incompatible extension from taking down the parent RIFT process.Validation
31 passedacrosstest_teobresums_compat.py,test_advanced_parameter_ports.py, andtest_hyperpipeline_io.py.154 passedfor those suites plus the CI integrator-accounting, CIP-prior, and cosmology-source tests; the three new advanced EOB priors now have explicit support and normalization coverage.266 passed, 1 skipped; the three ground-based external-TEOB options are explicitly classified as not applicable to the current LISA waveform path in the generated drift ledger.pyflakesclean for the new helper and tests; staged diff whitespace check clean.9c4482d9) generated a finite hyperbolic waveform and classified the test point as zoom-whirl./home/jacob.lange/.conda/envs/20260204-Ecc-Tides-container-mylalsuite-env, DALI extension SHA-256bade0374...) passed both hyperbolic generation and a combined eccentric + precessing + tidal +a6cwaveform (3,353 finite samples).26f2343e) passed profile detection and finite waveform generation.No files under
RIFT/integrators/change, so the posterior shape-recovery gate is not triggered.Remaining follow-up