chore: fix audit violations and host-level error detection - #35
Merged
Conversation
|
Thank you for contributing to this project! 😊🕹️ |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #35 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 1863 1863
=========================================
Hits 1863 1863
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
retr0h
force-pushed
the
chore/fix-audit-violations-v2
branch
from
March 29, 2026 22:02
e597370 to
b423838
Compare
- Delete docs/gen/ (re-added by PR #32 after cleanup) - Remove gomarkdoc from go.mod tools - Fix README: add pkg.go.dev badge/link, emoji headers - Consolidate TestStructToMapUnmarshalError into TestStructToMap - Fix OnlyIfAnyHostFailed/OnlyIfAllHostsFailed to check hr.Error in addition to hr.Status, so commandError exit codes trigger host failure guards (skipped hosts excluded) - Add cleanup phase to cron.go example - Fix agent-drain.go to use first discovered agent as default 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
retr0h
force-pushed
the
chore/fix-audit-violations-v2
branch
from
March 29, 2026 22:04
b423838 to
099800d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #32 (engine consolidation) was branched before our cleanup PRs merged,
re-introducing
docs/gen/and gomarkdoc. Also found bugs in host-levelfailure guards that only checked
hr.Statusbut nothr.Error.docs/gen/and remove gomarkdoc fromgo.modTestStructToMapUnmarshalErrorintoTestStructToMapOnlyIfAnyHostFailed/OnlyIfAllHostsFailedto checkhr.Error(not just
hr.Status), socommandErrorexit codes trigger guards.Skipped hosts (Status=skipped) are excluded from failure detection.
cron.goexampleagent-drain.goto use first discovered agent as defaultTest plan
just testpasses with 100% coveragejust go::vetpasses with 0 issueserror-recovery.goPlan 2 cleanup runs on command failurebroadcast-guards.gocleanup runs on command failure🤖 Generated with Claude Code