fix(go): handle 100% coverage in unit-cov-gaps - #29
Merged
Conversation
With `set -euo pipefail`, the `grep -v` pipeline returns exit code 1 when no lines match (i.e., when coverage is 100%), killing the script before the empty-check on line 105. Append `|| true` so the empty result flows through to the existing `if [ -z ]` guard. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Thank you for contributing to this project! 😊🕹️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unit-cov-gapsrecipe failing with exit code 1 when coverage is 100%set -euo pipefail,grep -v '100.0%'returns exit code 1 when no lines match (all functions at 100%), killing the script before theif [ -z ]guard|| trueto the pipeline so the empty result flows to the existing empty-check logicTest plan
just go::unit-cov-gapson a project with 100% coverage — should print "No coverage gaps found." and exit 0just go::unit-cov-gapson a project with <100% coverage — should open the heatmap as before🤖 Generated with Claude Code