fix: allow the parenthesized (Apache-2.0 AND MIT) SPDX expression - #181
Merged
Conversation
posthog-js declares its license as "(Apache-2.0 AND MIT)". The allow-list only contained the unparenthesized form, so the exact-string match rejected it even though both licenses are individually allowed.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tricky42
self-requested a review
August 20, 2026 11:48
tricky42
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(Apache-2.0 AND MIT)SPDX expression in the license allow-list; the unparenthesized form was already allowed, but the exact-string match rejected the parenthesized variant thatposthog-js@1.415.1declaresORY_CI_REFasset pin inlicenses/installto the commit containing the fix, so curl-install consumers receive itThis fixes the nightly
Validation - LicensesworkflowPlease merge with a merge commit (not squash) so the pinned SHA
915e79fc0d3dfca87bdfcb19485db8a84d8c9e6bis an ancestor of master.Verification
make testinlicenses/(ShellCheck + shfmt) passes"posthog-js@1.415.1","(Apache-2.0 AND MIT)"and still rejectsGPL-3.0and superset expressions such as(Apache-2.0 AND MIT AND GPL-3.0)licenses/installfrom this branch in an empty directory; it downloads the engine at the new pin and the check passes on the posthog-js line