fix(session-creator): refine worktree source modal - #851
Merged
Conversation
Pre-commit hook ran. Total eslint: 5, total circular: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The worktree source dialog used custom modal actions and compact input treatments that did not match the work-item picker. Its Smart and Name entry paths duplicated the clearer Branch/GitHub choices, branch ordering could bury the current/default branches, and checked-out worktrees used a different icon from Branch Spotlight.
Solution
Use the standard large Modal action props with localized Cancel/Create labels, keep only Branch and GitHub tabs with Branch selected by default, and align search, refresh, tabs, rows, spacing, and icons with the existing design-system patterns. Promote the current branch and conventional default branches to the top without duplicating them, preserve worktree metadata, and localize the dialog states across all supported session locales.
Potential risks
The removed Smart and Name tabs are no longer available by design; users choose a branch/ref or GitHub item instead. Default-branch promotion recognizes the same conventional names as Branch Spotlight (main, master, develop, dev), so repositories with a nonstandard default still rely on current/recent ordering. No API, persistence, schema, or dependency changes are included. Rollback is a direct revert of commit 6c506a4.
Verification
npx vitest run src/features/SessionCreator/components/WorktreeSourceModal.test.ts src/features/SessionCreator/components/__tests__/worktreeBranchSource.test.ts src/features/SessionCreator/components/__tests__/worktreeSmartInput.test.ts— 57 tests passed.npm run typecheck— passed.No final-state screenshot was attached because desktop Computer Use is explicit opt-in in this workspace and was not requested; component-level assertions cover modal props, tab order/treatment, GitHub SVG usage, and compact row sizing.
Audit
The configured
frontend-ui-auditskill was unavailable at both documented locations. A manual design-system review confirmed use of standard Modal, SearchInput, Button, ListPanel, GitHub asset, and Branch Spotlight patterns.