Keep chat composer full size - #846
Open
Harry19081 wants to merge 1 commit into
Open
Conversation
Pre-commit hook ran. Total eslint: 5, total circular: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The chat input could collapse into a compact pill in maximized and contextual presentations. That separate layout path also hid or changed ordinary composer controls and required a resize observer to switch back to the full editor.
Solution
Remove the compact presentation, pill shell variant, inline ComposerBar layout, compact editor styles, and expansion observer. Default and contextual chat inputs now always use the shared full-size stacked composer, while existing edit-mode surfaces remain unchanged.
Potential risks
Contextual Canvas prompts now occupy the full composer height and expose the standard toolbar controls, so their visual footprint is larger by design. No persistence, API, IPC, or wire behavior changes. Rollback is a direct revert of commit
ae8500d96.Audit
The architecture sweep covered presentation types, compact-layout control flow, dead code, shared component boundaries, defaults, and naming. Backend wire, initialization, and resolver layers were not applicable. The configured frontend UI audit skill was unavailable in this workspace.
Verification
npx vitest run src/components/ComposerBar/index.test.ts src/engines/ChatPanel/InputArea/__tests__/inputAreaPresentation.test.ts src/engines/ChatPanel/InputArea/components/InputComposerBars.test.ts src/engines/ChatPanel/InputArea/components/InputEditor.test.ts src/engines/Simulator/apps/canvas/design/CanvasDesignSurface.test.ts— 5 files, 15 tests passed.npx eslint src/components/ComposerBar/index.tsx src/components/ComposerShell/index.tsx src/engines/ChatPanel/InputArea/__tests__/inputAreaPresentation.test.ts src/engines/ChatPanel/InputArea/components/InputAreaChrome.tsx src/engines/ChatPanel/InputArea/components/InputComposerBars.test.ts src/engines/ChatPanel/InputArea/components/InputComposerBars.tsx src/engines/ChatPanel/InputArea/components/InputEditor.test.ts src/engines/ChatPanel/InputArea/components/InputEditor.tsx src/engines/ChatPanel/InputArea/index.tsx src/engines/ChatPanel/InputArea/inputAreaPresentation.ts— passed.npm run typecheck— passed.git diff --check— passed.No screenshot was captured because local UI control is explicit opt-in; the component and Canvas integration tests cover the changed presentation contract.