Support for subscribed region selection in monitoring and logging mcp servers - #417
Open
das-nirupam wants to merge 5 commits into
Open
Support for subscribed region selection in monitoring and logging mcp servers#417das-nirupam wants to merge 5 commits into
das-nirupam wants to merge 5 commits into
Conversation
das-nirupam
requested review from
AlaaShaker,
gebhardtr and
krisrice
as code owners
August 14, 2026 04:20
dustin-sale
requested changes
Aug 14, 2026
dustin-sale
left a comment
Contributor
There was a problem hiding this comment.
Review by @dustin-sale via Codex.
Requested changes
src/oci-logging-mcp-server/oracle/oci_logging_mcp_server/server.py:145— [P1] Use the required shared authentication layer.src/oci-monitoring-mcp-server/oracle/oci_monitoring_mcp_server/server.py:133— [P1] Route Monitoring discovery through the shared authentication layer.src/oci-logging-mcp-server/CHANGELOG.md:3— [P1] Release Logging as version 2.1.0.src/oci-monitoring-mcp-server/CHANGELOG.md:3— [P1] Release Monitoring as version 2.1.0.
Additional review notes
oracle-mcp-commoncentralizes OCI credential resolution, signer construction, and HTTP IDCS token exchange. See issue #366 and PR #367.- Follow
src/oci-cloud-mcp-serveras the reference integration: usebuild_auth_context()for stdio andbuild_idcs_http_auth()with per-requestcontext_for(...)for HTTP. src/oci-monitoring-mcp-server/oracle/oci_monitoring_mcp_server/server.py:163— [P2] Keep the synchronous SDK call off the event loop.
Validation
- Current lint and per-server tests passed; coverage was 94.99% for Logging and 92.72% for Monitoring.
- After applying the requested authentication and release changes, refresh each environment with
uv sync, validate installation withmake install, and rerun lint and tests.
See the inline comments in this review for evidence, impact, and suggested remediation.
This was referenced Aug 14, 2026
dustin-sale
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enhancement allows users to choose region from where they want monitoring and logging data when they are subscribed to multiple regions. So ir is no more limited to the region supplied via environment variable.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
When your tenancy is subscribed to multiple regions, you can provide any of those regions and get the data.
Test Configuration:
Checklist: