Skip to content

Support for subscribed region selection in monitoring and logging mcp servers - #417

Open
das-nirupam wants to merge 5 commits into
oracle:mainfrom
das-nirupam:monitoring
Open

Support for subscribed region selection in monitoring and logging mcp servers#417
das-nirupam wants to merge 5 commits into
oracle:mainfrom
das-nirupam:monitoring

Conversation

@das-nirupam

Copy link
Copy Markdown
Member

Description

This enhancement allows users to choose region from where they want monitoring and logging data when they are subscribed to multiple regions. So ir is no more limited to the region supplied via environment variable.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

When your tenancy is subscribed to multiple regions, you can provide any of those regions and get the data.

  • Unit test cases added for optional region input
  • Ran MCP server without providing region so it fallback to existing implementation
  • MCP server ran with user logged in to Phoenix region and provided region as both Ashburn and Phoenix to get data from both regions

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 14, 2026

@dustin-sale dustin-sale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by @dustin-sale via Codex.

Requested changes

  • src/oci-logging-mcp-server/oracle/oci_logging_mcp_server/server.py:145 — [P1] Use the required shared authentication layer.
  • src/oci-monitoring-mcp-server/oracle/oci_monitoring_mcp_server/server.py:133 — [P1] Route Monitoring discovery through the shared authentication layer.
  • src/oci-logging-mcp-server/CHANGELOG.md:3 — [P1] Release Logging as version 2.1.0.
  • src/oci-monitoring-mcp-server/CHANGELOG.md:3 — [P1] Release Monitoring as version 2.1.0.

Additional review notes

  • oracle-mcp-common centralizes OCI credential resolution, signer construction, and HTTP IDCS token exchange. See issue #366 and PR #367.
  • Follow src/oci-cloud-mcp-server as the reference integration: use build_auth_context() for stdio and build_idcs_http_auth() with per-request context_for(...) for HTTP.
  • src/oci-monitoring-mcp-server/oracle/oci_monitoring_mcp_server/server.py:163 — [P2] Keep the synchronous SDK call off the event loop.

Validation

  • Current lint and per-server tests passed; coverage was 94.99% for Logging and 92.72% for Monitoring.
  • After applying the requested authentication and release changes, refresh each environment with uv sync, validate installation with make install, and rerun lint and tests.

See the inline comments in this review for evidence, impact, and suggested remediation.

Comment thread src/oci-logging-mcp-server/oracle/oci_logging_mcp_server/server.py
Comment thread src/oci-monitoring-mcp-server/oracle/oci_monitoring_mcp_server/server.py Outdated
Comment thread src/oci-logging-mcp-server/CHANGELOG.md Outdated
Comment thread src/oci-monitoring-mcp-server/CHANGELOG.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants