fix: sync common package version during builds - #416
Conversation
Signed-off-by: mkt <quseijuro@gmail.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
@quseijuro-design I am wondering if instead of a script this can all be handled in the Makefile? My original investigation had something like this in Also, are you able to sign the OCA agreement? |
Signed-off-by: mkt <quseijuro@gmail.com>
|
Thanks for the suggestion. I agree. I’ll revise the change so the common-package version rewrite lives in _build, immediately before the existing server branch, and the CI build uses the same Makefile path rather than duplicating the logic. I have submitted the OCA, and it is currently under Oracle review. Once it is approved, I’ll update the branch accordingly. Does that match your intent? |
Summary
Closes #413.
oracle_mcp_common.__version__was stale because only server packages hadtheir runtime version metadata rewritten during builds. This updates the common
package from its
pyproject.tomlversion before local builds and CI builds.Changes
__version__declaration and preserves imports and__all__;make build-commonand the build workflow;Validation
uv tool run ruff checkuv run --no-sync --directory src/common pytest -q --basetemp .pytest-tmp(50 passed)
uv build --clearinsrc/commonpython scripts/sync_common_version.py --check src/common