development/api: Firewall - drop removed savepoint/rollback actions#892
Merged
AdSchellevis merged 1 commit intoJul 22, 2026
Merged
Conversation
The Firewall API reference documented a savepoint / rollback mechanism (savepoint(), apply(savepoint), cancelRollback(sp), revert()) that was removed from core in opnsense/core#10411 (released in 26.7, tracked by opnsense/core#10235). Update the reference to the current apply-only flow: rewrite the Concept section and blockdiag to a plain apply() step, drop the rollback-related Tip and Note, replace the savepoint example with a plain apply example (firewall.apply.py), and clean the filter_base endpoint table (apply without $rollback_revision, remove cancel_rollback / revert / savepoint). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
@chrstnth thanks, we forgot about the docs here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Firewall API reference documented a savepoint / rollback mechanism
(
savepoint(),apply(savepoint),cancelRollback(sp),revert()) thatwas removed from core in opnsense/core#10411 (released in 26.7, tracked by
opnsense/core#10235).
This updates the reference to the current apply-only flow:
apply()step(
firewall.apply.py, replacingfirewall.savepoint.py)filter_baseendpoint table (applywithout$rollback_revision, removecancel_rollback/revert/savepoint)The
filter_basetable was edited in place rather than regenerated infull, to keep this change scoped to the savepoint removal; the rest of the
firewall endpoint tables carry unrelated drift that a full
collect_api_endpoints.pyrefresh would pick up.closes #891