Expose RoPE theta via config API; cache fp32 cos/sin tables - #320
Open
KakaruHayate wants to merge 3 commits into
Open
Expose RoPE theta via config API; cache fp32 cos/sin tables#320KakaruHayate wants to merge 3 commits into
KakaruHayate wants to merge 3 commits into
Conversation
KakaruHayate
force-pushed
the
feat/expose-rope-config
branch
2 times, most recently
from
August 8, 2026 03:42
ffba20b to
3956360
Compare
KakaruHayate
force-pushed
the
feat/expose-rope-config
branch
from
August 8, 2026 04:00
3956360 to
f5ba7b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes in one PR:
rope_theta(plus existingrope_interleaved) through the encoder, so RoPE theta is config-tunable instead of hardcoded to 10000.modules/commons/rotary_embedding_torch.py), per review comments:cos/sinat init instead of raw angles, so trig runs once instead of every forward;einops, simplifying exported ONNX graphs (no Cos/Sin/Einsum ops).Compatibility
fp32 path is bit-identical to the previous implementation; only the fp16/bf16 column improves in precision. Buffers remain
persistent=False, so no checkpoint or config changes — existing models resume seamlessly. No tests included, per repo convention (verified via normal community testing).