Skip to content

Update vclient.c - #120

Open
ergorion wants to merge 1 commit into
openv:masterfrom
ergorion:master
Open

Update vclient.c#120
ergorion wants to merge 1 commit into
openv:masterfrom
ergorion:master

Conversation

@ergorion

Copy link
Copy Markdown

small fix to allow the output of system time in a csv file.

small fix to allow the output of system time in a csv file.
@hmueller01

hmueller01 commented Feb 14, 2023

Copy link
Copy Markdown
Collaborator

I think it's not good to have getSystemTime hard coded in vclient.c. It's just a tag in vito.xml, e.g.:

    <command name="getSystemTime" protocmd="getaddr">
      <addr>088E</addr>
      <len>8</len>
      <unit>TI</unit>
      <description>Ermittle Systemzeit</description>
      <device ID="2053"/>
    </command>

But I don't have a better idea right now ...

@ergorion

Copy link
Copy Markdown
Author

You are right, it's hard coded. But it helps people to simply output the system date... From what I saw on the web, I was not the only one with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants