Fix bad start call error name

[JohnReedV]

Description

Fixes the misspelled start-call readiness error returned by do_start_call.

What Changed

• Added a correctly named StartCallNotReady pallet error.
• Updated pallets/subtensor/src/subnets/subnet.rs so do_start_call returns StartCallNotReady when the subnet has not waited enough blocks after registration.
• Bumped runtime/src/lib.rs spec_version from 423 to 424 because the runtime metadata/error surface changes.

Behavioral Impact

The start-call readiness check is unchanged. Calls made before StartCallDelay has elapsed still fail, but now report the corrected StartCallNotReady error instead of NeedWaitingMoreBlocksToStarCall.

Testing

Not specified in the PR body. This is a narrow error rename with no logic change.

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: established write-permission opentensor contributor; no Gittensor allowlist hit found; branch fix-start-call-error -> devnet-ready.

No .github/ review-control files, dependencies, build scripts, unsafe code, origin checks, or arithmetic paths are changed. The prior runtime-versioning concern is addressed by the spec_version bump from 423 to 424.

Findings

No findings.

Prior-comment reconciliation

• d503277f: addressed — The current diff bumps runtime/src/lib.rs spec_version from 423 to 424, addressing the prior runtime-versioning finding.

Conclusion

This PR is a narrow runtime error rename plus the required runtime spec_version bump. I found no malicious behavior or security vulnerability in the current diff.

---

📜 Previous run (superseded)

Sev	File	Finding	Status
HIGH	pallets/subtensor/src/subnets/subnet.rs:388	Runtime behavior changed without spec_version bump	✅ Addressed The current diff bumps runtime/src/lib.rs spec_version from 423 to 424, addressing the prior runtime-versioning finding.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor association: UNKNOWN (no allowlist hit); author is an established write-permission opentensor contributor.

PR body was empty/trivial; the Auditor has auto-filled it. Please review.

No domain findings. The PR appends the corrected StartCallNotReady error and switches do_start_call to return it; the legacy misspelled variant remains in the enum, which avoids shifting existing error ordering. runtime/src/lib.rs includes the required spec_version bump from 423 to 424.

I did not run build/tests; static review was sufficient for this narrow runtime error rename.

Findings

No findings.

Conclusion

This is a minimal runtime metadata/error-name fix with the spec bump included. I found no correctness, safety, migration, weight, origin, or duplicate-work issue that should block merge.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍